#6449: [with patches, not ready for review] Additive abelian groups
-----------------------------+----------------------------------------------
Reporter: davidloeffler | Owner: joyner
Type: defect | Status: needs_work
Priority: major | Milestone: sage-feature
Component: group_theory | Keywords: abelian group
Work_issues: | Author: David Loeffler
Upstream: N/A | Reviewer:
Merged: |
-----------------------------+----------------------------------------------
Changes (by newvalueoldvalue):
* keywords: => abelian group
* upstream: => N/A
* author: => David Loeffler
Comment:
I'm hoping that we can sort this out and get it finished!
Comments on the patches:
1. Lines 47-53 of patch 1. Not sure I understand the issue here.
Isn't each coordinate just reduced modulo the appropriate integer (if
positive)?
2. Some functionality (e.g. annihilator()) is presumably inherited
from one of the base classes. I think it would help if this was written
down explicitly in comments, especially as there is more than one base
class.
3. As well as an is_multiplicative() returning False, should tere not
be an is_additive() returning True? Or does that exist already from a
base class?
4. You mention a black-box discrete log would be desirable. We have
that in sage/groups/generic.py -- does that do what is needed here? Or is
the problem that that only deals with the cyclic case?
5. Patch 2 looks quite simple, I have not looked at it in detail.
6. Patch 3 is mainly changes on doctest output, but also shows how
some code can be simplified using the new framework, which is good.
Now I'll actually try applying the patches to 4.3 and see how it looks.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6449#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
