#7145: Interval exchange transformations
-----------------------------+----------------------------------------------
Reporter: vdelecroix | Owner: vdelecroix
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.3.1
Component: combinatorics | Keywords:
Work_issues: | Author: Vincent Delecroix
Upstream: N/A | Reviewer:
Merged: |
-----------------------------+----------------------------------------------
Changes (by vdelecroix):
* status: needs_work => needs_review
Comment:
Replying to [comment:8 slabbe]:
Dear Sebastien,
>
> Thanks for doing all those changes.
>
Thanks for this nice review ! It will be a *very* good patch.
> ONE.
>
> > The resason is because it's possible to change the alphabet
> > sage: p = PermutationIET('a b c','c b a')
> > sage: p a b c c b a
> > sage: p.alphabet = [1,2,3]
> > sage: p 1 2 3 3 2 1
> > sage: p.alphabet = 'cd'
> > ...
> > ValueError?: Your alphabet has not enough letters
>
> I am not sure this is a good reason for using an attribute instead of a
method. See the following example :
>
> {{{
> sage: g = Graph()
> sage: p = g.plot()
> sage: p.xmin()
> -1.0
> sage: p.xmin(-2)
> sage: p.xmin()
> -2.0
> }}}
It works now as
{{{
sage: p = iet.Permutation('a b c','c b a')
sage: print p
a b c
c b a
sage: p.alphabet([1,2,3])
sage: print p
1 2 3
3 2 1
}}}
> TWO.
>
> The documentation and doctest coverage is very good (96%) but not
perfect :
>
up to 100% now
> While you are at it, you may consider to add some INPUT and OUTPUT where
there are missing. See the discussion [http://groups.google.com/group
/sage-
devel/browse_thread/thread/7d529c646c685877/3f7678e55f60759f?hl=en&lnk=gst&q=coverage#3f7678e55f60759f
sage-devel: input and output in docstrings]
lot of INPUT/OUTPUT added
> THREE.
>
> I am getting 2 doctests failures :
>
corrected
>
> FIVE.
>
> I changed a little bit the {{{_repr_}}} of Interval exchange
transformation. See the patch attached. Hope you agree.
>
I realy agree. In France, we use the coma instead of points to distinguish
the integer part and the decimal that why we use dot comman for
intervals... I keep it for the french translation ;-)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7145#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
