#7754: Weyl group optimizations [with patch, positive review]
-----------------------------+----------------------------------------------
Reporter: nthiery | Owner: nthiery
Type: enhancement | Status: positive_review
Priority: major | Milestone:
Component: combinatorics | Keywords: Weyl groups
Work_issues: | Author: Nicolas M. Thiéry
Upstream: N/A | Reviewer: Daniel Bump
Merged: |
-----------------------------+----------------------------------------------
Changes (by bump):
* status: needs_review => positive_review
Comment:
I tested this patch without #7753. I tested it with and without the
patch in #7751.
It is a very substantial speedup. It cuts a few
seconds off {{{sage -t weyl_groups.py}}} but more importantly it about
doubles the speed of computing the reduced word of a Weyl group element,
which is the basis of most combinatorial algorithms.
There are three patch fragments, one replacing the hash method with the
hash of the underlying matrix, one replacing the {{{__eq__}}} method, and
one unraveling some unnecessary complexity in the Weyl group action. I
tested each patch fragment separately and found that they are all
speedups, the last one being very significant.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7754#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
