#7820: upgrade gfan to latest release (0.4plus)
---------------------------+------------------------------------------------
   Reporter:  AlexGhitza   |       Owner:  tbd        
       Type:  enhancement  |      Status:  needs_work 
   Priority:  major        |   Milestone:  sage-4.3.1 
  Component:  packages     |    Keywords:             
Work_issues:               |      Author:  Alex Ghitza
   Upstream:  N/A          |    Reviewer:             
     Merged:               |  
---------------------------+------------------------------------------------
Changes (by newvalueoldvalue):

  * status:  new => needs_work
  * author:  => Alex Ghitza


Comment:

 An updated spkg is up at

 http://sage.math.washington.edu/home/ghitza/gfan-0.4plus.spkg

 Some fixes are needed in the Sage library because of the upgrade.  I am
 attaching a patch that deals with the most obvious one, but there are some
 doctest failures left:

 {{{
 sage -t -long "devel/sage-main/sage/rings/polynomial/groebner_fan.py"
 **********************************************************************
 File "/virtual/scratch/ghitza/sage-4.3/devel/sage-
 main/sage/rings/polynomial/groebner_fan.py", line 301:
     sage: pf.rays()
 Expected:
     [[1, 0, 0], [-2, -1, 0], [1, 1, 0], [0, -1, 0], [-1, 1, 0]]
 Got:
     [[-1, 0, 1], [-1, 1, 0], [1, -2, 1], [1, 1, -2], [2, -1, -1]]
 **********************************************************************
 File "/virtual/scratch/ghitza/sage-4.3/devel/sage-
 main/sage/rings/polynomial/groebner_fan.py", line 354:
     sage: pf._str_()
 Expected:
     '_application PolyhedralFan\n_version 2.2\n_type
 PolyhedralFan\n\nAMBIENT_DIM\n3\n\nDIM\n3\n\nLINEALITY_DIM\n0\n\nRAYS\n1 0
 0\t# 0\n0 1 0\t# 1\n0 0 1\t#
 2\n\nN_RAYS\n3\n\nLINEALITY_SPACE\n\nORTH_LINEALITY_SPACE\n0 0 1\n0 1 0\n1
 0 0\n\nF_VECTOR\n1 3 3 1\n\nCONES\n{}\t# Dimension 0\n{0}\t# Dimension
 1\n{1}\n{2}\n{0 1}\t# Dimension 2\n{0 2}\n{1 2}\n{0 1 2}\t# Dimension
 3\n\nMAXIMAL_CONES\n{0 1 2}\t# Dimension 3\n\nPURE\n1\n'
 Got:
     '_application PolyhedralFan\n_version 2.2\n_type
 PolyhedralFan\n\nAMBIENT_DIM\n3\n\nDIM\n3\n\nLINEALITY_DIM\n0\n\nRAYS\n0 0
 1\t# 0\n0 1 0\t# 1\n1 0 0\t#
 2\n\nN_RAYS\n3\n\nLINEALITY_SPACE\n\nORTH_LINEALITY_SPACE\n1 0 0\n0 1 0\n0
 0 1\n\nF_VECTOR\n1 3 3
 1\n\nMY_EULER\n0\n\nSIMPLICIAL\n1\n\nPURE\n1\n\nCONES\n{}\t# Dimension
 0\n{0}\t# Dimension 1\n{1}\n{2}\n{0 1}\t# Dimension 2\n{0 2}\n{1 2}\n{0 1
 2}\t# Dimension 3\n\nMAXIMAL_CONES\n{0 1 2}\t# Dimension 3\n'
 **********************************************************************
 File "/virtual/scratch/ghitza/sage-4.3/devel/sage-
 main/sage/rings/polynomial/groebner_fan.py", line 413:
     sage: pf.rays()
 Expected:
     [[1, 0, 0], [-2, -1, 0], [1, 1, 0], [0, -1, 0], [-1, 1, 0]]
 Got:
     [[-1, 0, 1], [-1, 1, 0], [1, -2, 1], [1, 1, -2], [2, -1, -1]]
 **********************************************************************
 File "/virtual/scratch/ghitza/sage-4.3/devel/sage-
 main/sage/rings/polynomial/groebner_fan.py", line 138:
     sage: _cone_parse(tstr.fan_dict['CONES'])
 Expected:
     {1: [[0], [1], [3], [2], [4]], 2: [[2, 4]]}
 Got:
     {1: [[0], [1], [2], [3], [4]], 2: [[2, 3]]}
 **********************************************************************
 File "/virtual/scratch/ghitza/sage-4.3/devel/sage-
 main/sage/rings/polynomial/groebner_fan.py", line 824:
     sage: pf.rays()
 Expected:
     [[1, 0, 0], [0, 1, 0], [0, 0, 1]]
 Got:
     [[0, 0, 1], [0, 1, 0], [1, 0, 0]]
 **********************************************************************
 File "/virtual/scratch/ghitza/sage-4.3/devel/sage-
 main/sage/rings/polynomial/groebner_fan.py", line 1243:
     sage: G.tropical_basis()
 Exception raised:
     Traceback (most recent call last):
       File "/virtual/scratch/ghitza/sage-4.3/local/bin/ncadoctest.py",
 line 1231, in run_one_test
         self.run_one_example(test, example, filename, compileflags)
       File "/virtual/scratch/ghitza/sage-4.3/local/bin/sagedoctest.py",
 line 38, in run_one_example
         OrigDocTestRunner.run_one_example(self, test, example, filename,
 compileflags)
       File "/virtual/scratch/ghitza/sage-4.3/local/bin/ncadoctest.py",
 line 1172, in run_one_example
         compileflags, 1) in test.globs
       File "<doctest __main__.example_48[5]>", line 1, in <module>
         G.tropical_basis()###line 1243:
     sage: G.tropical_basis()
       File "/virtual/scratch/ghitza/sage-4.3/local/lib/python/site-
 packages/sage/rings/polynomial/groebner_fan.py", line 1267, in
 tropical_basis
         X = [S(f) for f in B]
       File "multi_polynomial_libsingular.pyx", line 608, in
 
sage.rings.polynomial.multi_polynomial_libsingular.MPolynomialRing_libsingular.__call__
 (sage/rings/polynomial/multi_polynomial_libsingular.cpp:5471)
         raise TypeError
     TypeError
 **********************************************************************
 File "/virtual/scratch/ghitza/sage-4.3/devel/sage-
 main/sage/rings/polynomial/groebner_fan.py", line 1294:
     sage: pf.rays()
 Expected:
     [[-1, 0, 0]]
 Got:
     [[-2, 1, 1]]
 **********************************************************************
 7 items had failures:
    1 of   7 in __main__.example_11
    1 of   6 in __main__.example_13
    1 of   7 in __main__.example_17
    1 of   8 in __main__.example_3
    1 of   6 in __main__.example_35
    1 of   6 in __main__.example_48
    1 of   7 in __main__.example_50
 ***Test Failed*** 7 failures.
 For whitespace errors, see the file
 /home/ghitza/.sage//tmp/.doctest_groebner_fan.py
          [8.1 s]
 exit code: 1024

 ----------------------------------------------------------------------
 The following tests failed:


         sage -t -long "devel/sage-
 main/sage/rings/polynomial/groebner_fan.py"
 Total time for all tests: 8.2 seconds
 }}}

 I can try to figure out what's happening, but Marshall is likely to be
 better at it.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7820#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--

You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.


Reply via email to