#7836: Clean up the CRT_* functions
--------------------------------+-------------------------------------------
Reporter: mhansen | Owner: AlexGhitza
Type: defect | Status: new
Priority: major | Milestone: sage-4.3.1
Component: basic arithmetic | Keywords:
Work_issues: | Author:
Upstream: N/A | Reviewer:
Merged: |
--------------------------------+-------------------------------------------
Description changed by mhansen:
Old description:
> From #7595:
>
> Replying to [comment:10 cremona]:
> > I have some problems with the CRT* functions though.
> >
> > 1. CRT_list does not check that the two lists have the same length;
> if the moduli list is shorter you get an IndexError, but it would be
> better to catch that and raise a more informative error.
> >
> > 2. CRT_basis is rather silly. It calls CRT_list n times with the
> same moduli, which must be wasteful. It would be better to call plain
> CRT n times with suitable moduli (exercise for the reader).
> >
> > Of course, I don't think that these issues should delay the current
> patch, but deserve a ticket of their own to make sure they are tided up.
> }}}
New description:
From #7595:
{{{
> I have some problems with the CRT* functions though.
>
> 1. CRT_list does not check that the two lists have the same length;
if the moduli list is shorter you get an IndexError, but it would be
better to catch that and raise a more informative error.
>
> 2. CRT_basis is rather silly. It calls CRT_list n times with the
same moduli, which must be wasteful. It would be better to call plain CRT
n times with suitable moduli (exercise for the reader).
>
> Of course, I don't think that these issues should delay the current
patch, but deserve a ticket of their own to make sure they are tided up.
}}}
--
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7836#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
