#7128: zlib-1.2.3.p4 always builds 32-bit binaries on Solaris.
------------------------+---------------------------------------------------
Reporter: drkirkby | Owner: tbd
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.3.1
Component: porting | Keywords:
Work_issues: | Author: David Kirkby
Upstream: N/A | Reviewer:
Merged: |
------------------------+---------------------------------------------------
Changes (by newvalueoldvalue):
* cc: david.kir...@… (removed)
* cc: jsp (added)
* status: new => needs_review
* author: => David Kirkby
Comment:
I've sorted this out for Solaris. Currently the option added is always
-m64, which is not ideal, as it will break with compilers other than GNU
or Sun, but when #7818 get added, sorting this lot out will be a lot
easier.
On OS X, not only is -m64 added to the flags, but an altered version of a
configure script is copied too. There is no need to change the configure
script on Solaris, so OS X is still handled differently.
'''Previous code:'''
{{{
if [ "x`uname`" = "xDarwin" ] && [ "x$SAGE64" = "xyes" ]; then
CFLAGS=" -m64 $CFLAGS -fPIC -g -I\"$SAGE_LOCAL/include\""
cp ../patches/configure-OSX-64 configure
else
CFLAGS="$CFLAGS $FPIC_FLAG -g -I\"$SAGE_LOCAL/include\""
fi
}}}
Revised code:
{{{
if [ "x`uname`" = "xDarwin" ] && [ "x$SAGE64" = "xyes" ]; then
CFLAGS=" -m64 $CFLAGS -fPIC -g -I\"$SAGE_LOCAL/include\""
cp ../patches/configure-OSX-64 configure
elif [ "x`uname`" != "xDarwin" ] && [ "x$SAGE64" = "xyes" ]; then
CFLAGS="-m64 $CFLAGS $FPIC_FLAG -g -I\"$SAGE_LOCAL/include\""
else
CFLAGS="$CFLAGS $FPIC_FLAG -g -I\"$SAGE_LOCAL/include\""
fi
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7128#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
