#7873: Fix 'gap' to remove usage of '$RM' and replace wth 'rm'
------------------------+---------------------------------------------------
Reporter: drkirkby | Owner: GeorgSWeber
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.3.1
Component: build | Keywords:
Work_issues: | Author: David Kirkby
Upstream: N/A | Reviewer:
Merged: |
------------------------+---------------------------------------------------
Comment(by drkirkby):
Replying to [comment:3 jhpalmieri]:
> Two comments: you've changed "$CP" to "cp" even though $CP is still
defined in sage-env. Does this matter?
No. I looked at that before deciding to replace them, but could see no
reason not to in this case. One was a simple copy
{{{
cp patches/gap_cygwin "$SAGE_LOCAL"/bin/gap
}}}
the other was recursive, but simply used the POSIX compatible '-r' option.
There seemed to be no reason to use any other version of cp in such cases.
The GNU verison of 'cp' has some non-POSIX options (-a being one of them).
Had that be iused in gap, then I would have left the $CP, but in this
case, with only a very standard option used, there is no reason not to use
whatever version of 'cp' is in the path first. Any 'cp' will work.
> Also (and this is not new -- it happens with the old spkg, too): when I
install the spkg, I get this at the end:
> {{{
> cp: ../../bin is a directory (not copied).
> cp: cp: No such file or directory
> }}}
> Any ideas why? Anyway, since gap works, maybe we shouldn't worry about
this right now.
Looking at the 'cp' (or $CP) command I could not work out what spkg-
install was trying to do (I just posted something on sage-devel about it).
The code simply makes no sense to me.
Since
* The package functions, despite the errors.
* I wanted to do it asap, in case it caused an issue with the sage-env
ticket (#7818)
* I could not work out what was the intended behavior. 'cp' is used in a
way I'd never use it.
* There is talk on sage-devel of updating gap
it seemed like it was best left to another day. Like the fact CC and CXX
get unset. I think it would be wise to find a way around the issues this
creates, but again I did not attempt to fix it. That will certainly
present a problem if one tried to use a Sun compiler to build gap.
I'm not even convinced this will work in 64-bit mode on OS X, as it does
not have the SAGE64 stuff which every other spkg-install file has.
So, overall, the changes I made were only necessary ones, and no others.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7873#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
