#7954: Defining affine curves in 3D space
----------------------------------+-----------------------------------------
Reporter: wjp | Owner: AlexGhitza
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.3.1
Component: algebraic geometry | Keywords:
Work_issues: | Author:
Upstream: N/A | Reviewer:
Merged: |
----------------------------------+-----------------------------------------
Changes (by was):
* status: needs_review => needs_work
Comment:
Hi,
I made some important improvements to the patch while refereeing it.
However, it is clear after looking at this code for a bit that there is a
*MAJOR* design flaw (which Willem pointed out to me in person). The flaw
is this in plane_curve/affine_curve.py:
{{{
class AffineSpaceCurve_generic(Curve_generic,
AlgebraicScheme_subscheme_affine):
def _repr_type(self):
return "Affine Space"
}}}
However, Curve_generic is very much a *plane* curve:
{{{
class Curve_generic(AlgebraicScheme_subscheme):
...
def defining_polynomial(self):
return self.defining_polynomials()[0]
}}}
Thus the *isa* relationship that *must* be satisfied by derivation of
objects is broken.
The space curve code must be completely moved out of this directory to the
appropriate place.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7954#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
