#7650: Fix sagenb doctesting
------------------------+---------------------------------------------------
Reporter: mpatel | Owner: was
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-4.3.1
Component: notebook | Keywords:
Work_issues: | Author: Mitesh Patel
Upstream: N/A | Reviewer:
Merged: |
------------------------+---------------------------------------------------
Comment(by mpatel):
Yes, but it's already here. :) In the course of fixing many failed
doctests, I noticed it and a few other small problems:
* In `run_notebook.notebook_twisted`: Replaced `nb.directory()` (not
defined) with `nb._dir`.
* In `worksheet`: Replaced `self.__collaborators` (`AttributeError`) with
`self.collaborators()` in a few places.
* In `worksheet.set_filename`:
{{{
#!diff
- self.__dir = os.path.join(self.notebook().worksheet_directory(),
filename)
+ self.__dir = os.path.join(self.notebook()._dir, filename)
}}}
* In `worksheet.tags`:
{{{
#!diff
d = dict(self.__user_view)
except AttributeError:
self.user_view(self.owner())
- d = self.__user_view
+ d = copy.copy(self.__user_view)
for user, val in d.iteritems():
- d[user] = [val]
+ if not isinstance(val, list):
+ d[user] = [val]
return d
}}}
This ensures the tests in `Worksheet.reconstruct_from_basic` pass and
that calling `tags` does not alter the current user view, e.g., turning
`1` into `[1]`.
Also:
* Removed argument `verbose` (obsolete) from `Cell.set_introspect_html`.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7650#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
