#4509: [with patch; positive review] doctests for planarity code
----------------------------+-----------------------------------------------
   Reporter:  jason         |       Owner:  ekirkman  
       Type:  defect        |      Status:  new       
   Priority:  critical      |   Milestone:  sage-4.3.1
  Component:  graph theory  |    Keywords:            
Work_issues:                |      Author:            
   Upstream:  N/A           |    Reviewer:            
     Merged:                |  
----------------------------+-----------------------------------------------
Changes (by boothby):

  * upstream:  => N/A


Comment:

 Works for me and valgrinds clean:
 {{{
 boot...@sage:/scratch/boothby/sage-4.3$ ./sage -valgrind
 ----------------------------------------------------------------------
 | Sage Version 4.3, Release Date: 2009-12-24                         |
 | Type notebook() for the GUI, and license() for information.        |
 ----------------------------------------------------------------------
 /mnt/usb1/scratch/boothby/sage-4.3/local/bin/sage-ipython
 Log file is /home/boothby/.sage/valgrind/sage-memcheck.%p
 Using default flags:
 --leak-resolution=high --log-file=/home/boothby/.sage/valgrind/sage-
 memcheck.%p --leak-check=full --num-callers=25
 --suppressions=/mnt/usb1/scratch/boothby/sage-4.3/local/lib/valgrind/sage.supp
 Python 2.6.2 (r262, Jan 17 2010, 13:56:28)
 [GCC 4.4.1] on linux2
 Type "help", "copyright", "credits" or "license" for more information.
 print "hello world"
 sage: print "hello world"
 hello world
 sage: import networkx.generators.atlas  # long time
 sage: atlas_graphs = [Graph(i) for i in
 networkx.generators.atlas.graph_atlas_g()] # long time
 sage: a = [i for i in [1..1252] if atlas_graphs[i].is_planar()] # long
 time
 sage: b = [i for i in [1..1252] if atlas_graphs[i].is_planar()] # long
 time
 sage: b = [i for i in [1..1252] if atlas_graphs[i].is_planar()] # long
 time
 sage: b = [i for i in [1..1252] if atlas_graphs[i].is_planar()] # long
 time
 sage: b = [i for i in [1..1252] if atlas_graphs[i].is_planar()] # long
 time
 }}}

 I recommend we add the first patch and not the second, because it is
 unnecessary.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4509#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB
-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.


Reply via email to