#7535: Errors should be raised, not returned.
-------------------------+--------------------------------------------------
   Reporter:  SimonKing  |       Owner:  tbd          
       Type:  defect     |      Status:  needs_review 
   Priority:  critical   |   Milestone:  sage-4.3.1   
  Component:  misc       |    Keywords:  error return 
Work_issues:             |      Author:  Tim Dumol    
   Upstream:  N/A        |    Reviewer:  John Palmieri
     Merged:             |  
-------------------------+--------------------------------------------------
Changes (by newvalueoldvalue):

  * reviewer:  => John Palmieri
  * author:  => Tim Dumol


Comment:

 I'm not sure what you mean by "remaining", since there is no patch at
 #7532 (or elsewhere?) fixing any other instances of this.  I'm attaching a
 patch dealing with two more of these, leaving, I think, just the one in
 rings.pyx.  See #7532 for that one.

 Positive review for timdumol's patch, so if mine is okay, this whole
 ticket can get a positive review.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7535#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB
-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.


Reply via email to