#6018: Confusing behaviour with Dirichlet characters
-----------------------------+----------------------------------------------
Reporter: davidloeffler | Owner: craigcitro
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-4.3.1
Component: modular forms | Keywords: Dirichlet characters
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Comment(by craigcitro):
This looks like a nice clean fix -- my only worry would be that a few
subtle choices cause mayhem with some random modular symbols code.
William, did you run doctests on the `modular/` directory?
Also, one potentially silly comment: your fix assumes that the constructor
for `DirichletGroup` always chooses a maximal order and an appropriate
zeta if one isn't given. While I can't imagine us ever changing that
constructor to do anything different, should we either (1) explicitly
choose the maximal order or (2) check and/or document this in some way? I
think it's unlikely, but should it ever come up, a comment near that line
of code pointing someone in the right direction could be a huge help ...
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6018#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
