#2480: problem parsing arguments to NumberField.order()
-----------------------------+----------------------------------------------
Reporter: ncalexan | Owner: davidloeffler
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-4.3.1
Component: number fields | Keywords: number field order arguments
Author: Craig Citro | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Changes (by newvalueoldvalue):
* status: new => needs_review
* upstream: => N/A
* author: => Craig Citro
Comment:
This wasn't so bad -- the problem was that `gens=` put the list of gens in
the `kwds` dict, instead of in the `*`-argument. I've attached a fix, but
I'd love for someone to tell me if deleting `gens` out of the `kwds` dict
is sufficiently pythonic. (If you don't, the call to
`absolute_order_from_ring_generators` rightfully complains that `gens` is
specified twice.) Another option would be to reassign `kwds['dict']` at
the end, but I don't think that's any nicer. (In fact, that might be
epsilon slower, since it's another argument to unpack from the dictionary
on the other side.)
Also, the comment block in the docstring '''really''' looks like something
was accidentally cut off at some point. Amusingly, this isn't the case: I
actually dug through the hg logs, and it was really committed just like
that.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/2480#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
