#7879: Remove unnecessary signal handling for low prec mpfr operations.
--------------------------------+-------------------------------------------
Reporter: robertwb | Owner: AlexGhitza
Type: enhancement | Status: needs_info
Priority: minor | Milestone: sage-4.3.1
Component: basic arithmetic | Keywords:
Author: Robert Bradshaw | Upstream: N/A
Reviewer: Alex Ghitza | Merged:
Work_issues: |
--------------------------------+-------------------------------------------
Changes (by newvalueoldvalue):
* status: needs_review => needs_info
* reviewer: => Alex Ghitza
* author: => Robert Bradshaw
Comment:
This looks good. I have one question: you are hardcoding threshold
precisions after which the signals should be used, mostly 1000, but also
10000 in a couple of places. Would it be better to have a global variable
PREC_THRESHOLD set to 1000 at the top of the file, and then use it or
10*PREC_THRESHOLD where needed? It would make it easier to change this in
the future, since a search for it would be all that's needed.
I'm marking this as needs_info. If you think it's not worth the trouble,
I'll put a positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7879#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.