#5155: Sage 3.3.a3: fix doctests that want write access to $SAGE_LOCAL
---------------------------+------------------------------------------------
Reporter: mabshoff | Owner: mabshoff
Type: defect | Status: needs_work
Priority: critical | Milestone: sage-4.3.2
Component: doctest | Keywords:
Author: Mike Hansen | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
---------------------------+------------------------------------------------
Changes (by jhpalmieri):
* status: needs_review => needs_work
Comment:
Before applying the patch, I get two doctest failures (with a non-
writeable Sage install). Applying the patch "trac_5155.patch" fixes both.
So positive review for that.
The scripts patch wasn't necessary to get those tests to pass, and it also
doesn't apply cleanly to 4.3.1:
{{{
applying /Users/palmieri/Downloads/scripts_5155.patch
patching file sage-doctest
Hunk #1 FAILED at 55
1 out of 1 hunks FAILED -- saving rejects to file sage-doctest.rej
unable to find 'sage-dsage-trial' for patching
1 out of 1 hunks FAILED -- saving rejects to file sage-dsage-trial.rej
patching file sage-maketest
Hunk #1 succeeded at 1 with fuzz 1 (offset -1 lines).
patching file sage-test
Hunk #1 FAILED at 40
1 out of 1 hunks FAILED -- saving rejects to file sage-test.rej
sage-dsage-trial: No such file or directory
abort: patch failed to apply
}}}
The changes there look fine in principle, though. So once it's rebased,
positive review there, too.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5155#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
