#8008: Implement an rref() function which works over the fraction field of the
base ring of a matrix
----------------------------------+-----------------------------------------
   Reporter:  jason               |       Owner:  was       
       Type:  defect              |      Status:  needs_work
   Priority:  major               |   Milestone:            
  Component:  linear algebra      |    Keywords:            
     Author:  Jason Grout         |    Upstream:  N/A       
   Reviewer:  Sebastian Pancratz  |      Merged:            
Work_issues:  needs rebase        |  
----------------------------------+-----------------------------------------
Changes (by mvngu):

  * status:  positive_review => needs_work
  * work_issues:  => needs rebase


Comment:

 I got a hunk failure after applying
 [http://trac.sagemath.org/sage_trac/attachment/ticket/8008/trac-8008-rref.patch
 trac-8008-rref.patch], then
 
[http://trac.sagemath.org/sage_trac/attachment/ticket/8008/trac-8008-fixes.patch
 trac-8008-fixes.patch]:
 {{{
 [mv...@sage sage-main]$ hg qimport http://trac.sagemath.org/sage_trac/raw-
 attachment/ticket/8008/trac-8008-rref.patch && hg qpush
 adding trac-8008-rref.patch to series file
 applying trac-8008-rref.patch
 now at: trac-8008-rref.patch
 [mv...@sage sage-main]$ hg qimport http://trac.sagemath.org/sage_trac/raw-
 attachment/ticket/8008/trac-8008-fixes.patch && hg qpush
 adding trac-8008-fixes.patch to series file
 applying trac-8008-fixes.patch
 patching file sage/matrix/matrix2.pyx
 Hunk #3 FAILED at 4273
 1 out of 3 hunks FAILED -- saving rejects to file
 sage/matrix/matrix2.pyx.rej
 patch failed, unable to continue (try -v)
 patch failed, rejects left in working dir
 errors during apply, please fix and refresh trac-8008-fixes.patch
 [mv...@sage sage-main]$ cat sage/matrix/matrix2.pyx.rej
 --- matrix2.pyx
 +++ matrix2.pyx
 @@ -4267,12 +4274,14 @@
          """
          Return the echelon form of self.

 -        .. note:: This row reduction does not use division if the
 -        matrix is not over a field (e.g., if the matrix is over the
 -        integers).  If you want to calculate the echelon form using
 -        division, then use :meth:`rref`, which assumes that the matrix
 -        entries are in a field (specifically, the field of fractions
 -        of the base ring of the matrix).
 +        .. note::
 +
 +            This row reduction does not use division if the
 +            matrix is not over a field (e.g., if the matrix is over
 +            the integers).  If you want to calculate the echelon form
 +            using division, then use :meth:`rref`, which assumes that
 +            the matrix entries are in a field (specifically, the field
 +            of fractions of the base ring of the matrix).

          INPUT:
 }}}
 Perhaps this ticket needs a rebase?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8008#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to