#7544: downloading packages with sage-spkg
-----------------------------+----------------------------------------------
 Reporter:  mvngu            |         Owner:  tbd            
     Type:  defect           |        Status:  closed         
 Priority:  major            |     Milestone:  sage-4.3       
Component:  misc             |    Resolution:  fixed          
 Keywords:                   |        Author:  Minh Van Nguyen
 Upstream:  N/A              |      Reviewer:  Mike Hansen    
   Merged:  sage-4.3.alpha1  |   Work_issues:                 
-----------------------------+----------------------------------------------

Comment(by ddrake):

 Unfortunately, this patch breaks the functionality introduced at #7355.
 That ticket made it so that in sage-spkg, at line 195 (or so),
 {{{$PKG_NAME}}} (which we get from {{{$1}}}) has been munged so that if no
 version number was provided, the appropriate one has now been added.
 However, the patch here comments out the line that uses {{{$PKG_NAME}}}
 and simply uses {{{$1}}}, thereby bypassing everything that we try to do
 in #7355. This patch is supposed to be a followup to #7355, but it
 completely breaks everything that that ticket was intended to do! Even
 with a casual inspection of the code -- which amounts to changing one line
 -- it should have been pretty obvious that blithely using {{{$1}}} wasn't
 going to work.

 For example, if you try {{{sage -i vtk}}}, you'll see that it searches and
 finds that version 5.0.2 is the current version -- but then goes and tries
 to download a bare "vtk.spkg":
 {{{
 dr...@klee:/opt/sage$ sage -i vtk
 Installing vtk
 Calling sage-spkg on vtk
 Warning: Attempted to overwrite SAGE_ROOT environment variable
 vtk
 Machine:
 Linux klee 2.6.31-9-rt #152-Ubuntu SMP PREEMPT RT Thu Oct 15 13:22:24 UTC
 2009 x86_64 GNU/Linux
 Deleting directories from past builds of previous/current versions of vtk
 /opt/sage/local/bin/sage-spkg: file vtk does not exist
 Attempting to download it.
 Searching for latest version of vtk
 Found package vtk-5.0.2
 http://www.sagemath.org//packages/optional/vtk.spkg --> vtk.spkg
 [ ]
 http://www.sagemath.org//packages/standard/vtk.spkg --> vtk.spkg
 [ ]
 http://www.sagemath.org//packages/experimental/vtk.spkg --> vtk.spkg
 [ ]
 http://www.sagemath.org//packages/archive/vtk.spkg --> vtk.spkg
 [ ]
 **********************************************************************
 * Unable to download vtk
 * Please see http://www.sagemath.org//packages for a list of valid
 * packages or check the package name.
 **********************************************************************
 sage: Failed to download package vtk-5.0.2 from http://www.sagemath.org/
 }}}

 I'll open another ticket to fix this.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7544#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to