#7939: shorten doctests in sage/rings/polynomial/multi_polynomial_ideal.py
-------------------------------------------------+--------------------------
Reporter: rlm | Owner: tbd
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.3.2
Component: interfaces | Keywords:
Author: Martin Albrecht | Upstream: N/A
Reviewer: Michael Brickenstein, Alex Ghitza | Merged:
Work_issues: |
-------------------------------------------------+--------------------------
Changes (by AlexGhitza):
* status: needs_work => needs_review
* reviewer: => Michael Brickenstein, Alex Ghitza
Comment:
This looks good to me. There are only a few typos that are fixed by the
small referee patch. One last question: in
{{{rings/polynomial/multi_polynomial_ideal.py}}}, you left a handful of
lines commented out. Was this by purpose, or just an oversight?
Anyway, positive review for the updated spkg and Martin's patch. If
someone can have a quick look at the referee patch, we're done.
In terms of the original motivation for this ticket (what was it
already?): the file {{{rings/polynomial/multi_polynomial_ideal.py}}}
passes long doctests in 45 seconds now on my laptop -- not bad for 582
tests. I ran it with -verbose and didn't see anything that was outrageous
in terms of time.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7939#comment:29>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
