#7109: polyhedra bugs with linearities, rewrite proposal
---------------------------+------------------------------------------------
Reporter: vbraun | Owner: mhampton
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.3.2
Component: geometry | Keywords: polyhedra
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
---------------------------+------------------------------------------------
Comment(by AlexGhitza):
The new spkg has a few minor issues:
{{{
[ghi...@artin cddlib-094f-p2]$ hg status
M spkg-install
? .DS_Store
? patches/cdd_both_reps-make.patch
? patches/cdd_both_reps.c
}}}
I fixed all of this and put up the new spkg at
http://sage.math.washington.edu/home/ghitza/cddlib-094f-p2.spkg
Note that SPKG.txt is not in the correct format, but this will be another
ticket.
Now: There are obviously not enough patches on this ticket :) So I'm
adding another one. It is small and consists mostly of very minor typo
fixes. It also addresses one major issue: when I ran long doctests on
{{{geometry/polyhedra.py}}}, it timed out on me. Here is the reason:
{{{
----------------------------------------------------------------------
| Sage Version 4.3.1, Release Date: 2010-01-20 |
| Type notebook() for the GUI, and license() for information. |
----------------------------------------------------------------------
sage: time c5_20 = Polyhedron(vertices = [[i,i^2,i^3,i^4,i^5] for i in
range(1,21)])
CPU times: user 0.04 s, sys: 0.00 s, total: 0.04 s
Wall time: 244.51 s
sage: time c5_20_fl = c5_20.face_lattice()
CPU times: user 64.62 s, sys: 0.06 s, total: 64.68 s
Wall time: 64.78 s
sage: time [len(x) for x in c5_20_fl.level_sets()]
CPU times: user 0.22 s, sys: 0.00 s, total: 0.22 s
Wall time: 0.22 s
[1, 20, 190, 580, 680, 272, 1]
sage: time p600 = polytopes.six_hundred_cell()
CPU times: user 0.14 s, sys: 0.02 s, total: 0.16 s
Wall time: 3175.85 s
sage: time len(list(p600.bounded_edges()))
CPU times: user 0.02 s, sys: 0.00 s, total: 0.02 s
Wall time: 0.02 s
720
}}}
These tests are not just long, they are way too long to include. So I
have marked them as {{{#not tested}}}. If you can think of some way to
get them under 30 seconds each, they can go back in. I don't want to just
delete them since they are examples of usage.
One thing that I noticed but not fixed is that none of the geometry code
is in the reference manual at the moment. This should be another ticket.
In summary: I'm giving a positive review to everything so far; someone
needs to look at my patch. We'll sort out authors/reviewers/etc when it's
all done.
Summary for the release manager who will have to merge this: once
everything has a positive review, get the new spkg at
http://sage.math.washington.edu/home/ghitza/cddlib-094f-p2.spkg
then apply {{{trac_7109_mh2.patch}}} and {{{trac_7109_ag.patch}}}.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7109#comment:37>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
