#4756: eigenmatrix_right totally broken
------------------------------+---------------------------------------------
   Reporter:  was             |       Owner:  was         
       Type:  defect          |      Status:  needs_review
   Priority:  major           |   Milestone:  sage-4.3.2  
  Component:  linear algebra  |    Keywords:              
     Author:  Rob Beezer      |    Upstream:  N/A         
   Reviewer:                  |      Merged:              
Work_issues:                  |  
------------------------------+---------------------------------------------

Comment(by jason):

 Great job!

 I think these changes would make the code easier to read:

 {{{
         662             for k in range(len(spectrum)):
         663                 evalue = spectrum[k][0]
         664                 evector = spectrum[k][1][0]
         665                 pairs.append((evalue,
 evector.parent().span_of_basis([evector],check=False)))

 changed to

 for eval,evectors in spectrum:
     evec = evectors[0]
     evector = evec.parent().span_of_basis([evec],check=False)
     pairs.append((evalue, evector))

 }}}

 (similarly on lines 722-725)

 Also:

 {{{
 B = matrix(CDF, [spectrum[i][1][0] for i in
 range(len(spectrum))]).transpose()

 changed to

 B = matrix(CDF, [evecs[0] for _,evecs in spectrum]).transpose()

 }}}

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4756#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to