#8018: Eigenvalues sorted, but not eigenvectors, in modular/modform/numerical.py
-----------------------------+----------------------------------------------
   Reporter:  rbeezer        |       Owner:  craigcitro  
       Type:  defect         |      Status:  needs_review
   Priority:  major          |   Milestone:  sage-4.3.2  
  Component:  modular forms  |    Keywords:              
     Author:  Rob Beezer     |    Upstream:  N/A         
   Reviewer:                 |      Merged:              
Work_issues:                 |  
-----------------------------+----------------------------------------------
Changes (by newvalueoldvalue):

  * status:  new => needs_review
  * author:  => Rob Beezer


Comment:

 This patch depends on #4756 due to intermediate changes in some of the CDF
 eigenvector code, so apply that patch first.  Since this patch computes
 the eigenvalues directly, it is not necessary to understand #4756.

 Summary:

 1.  Return value has changed to be the subset of eigenvectors with
 multiplicity one, rather than all the eigenvectors.  First few lines
 (immediate return without recalculation) indicate this was the intent.

 2.  The eigenvalues do not get sorted now, fixing the observed bug.  An
 extra check of {{{uniq}}} will cause the loop to speed-up when the
 eigenvector has high multiplicity.

 3.  Eigenvalues and eigenvectors are computed directly via {{{SciPy}}}.
 This avoids various conversion overhead.

 4.  Lots of blank lines marked as changed in the patch file.  An accident
 of a massive cut/paste job to recover from an error.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8018#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to