#7978: Cleanup of crystal code
-------------------------------------------------+--------------------------
Reporter: jbandlow | Owner: sage-combinat
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.3.2
Component: combinatorics | Keywords: crystals
Author: Nicolas M. Thiery, Anne Schilling | Upstream: N/A
Reviewer: Dan Bump | Merged:
Work_issues: |
-------------------------------------------------+--------------------------
Changes (by newvalueoldvalue):
* status: needs_work => needs_review
* author: => Nicolas M. Thiery, Anne Schilling
* keywords: => crystals
* reviewer: => Dan Bump
Old description:
> They should be replaced with spaces.
New description:
Fixed some issues in crystals, such as
- Comparison of elements
- Latex output
- Fixes whitespaces in /combinat/crystals/affine.py (as reported by Jason
Bandlow)
- All crystals have unique representation
- Preparation of categorification of crystals:
- C.element_class -> C.Element
- All crystals are at least in the EnumeratedSets category
- Use rename, or define _repr_, instead of setting _name
Eventually, crystals should only use _repr_
=> Removed dependency upon deprecated CombinatorialClass
- Systematic use of TestSuite instead of loads/dumps test
- Fixed bug in fast_crystal: delpat is not immutable (which should be
eventually be fixed), and was accidentally changed by the weight
method). This was caught by turning on unique representation which
made the crystals to be reused longer in the tests.
Depends on trac ticket 8028 (element wrapper improvement)
--
Comment:
The patch trac_7978_crystal_cleanup-as.patch supersedes Jason's patch. It
fixes the whitespace issues in combinat/crystals/affine.py and does a lot
more improvements in crystals (see description).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7978#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
