#8076: gap-4.4.12.p2 - please test
------------------------+---------------------------------------------------
Reporter: dimpase | Owner: tbd
Type: defect | Status: new
Priority: major | Milestone: sage-4.3.2
Component: packages | Keywords: gap
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------+---------------------------------------------------
Comment(by was):
It builds fine, and Gap seems to work. The major workspaces issue seems
gone. Bravo! Thanks to Steve Linton and dimpase!
The repo needs to have its changed checked in:
{{{
wst...@iras:~/screen/iras/sage-4.3.1/gap-4.4.12.p2> ../sage -hg status
M .hgignore
M SPKG.txt
? patches/saveload.patch
wst...@iras:~/screen/iras/sage-4.3.1/gap-4.4.12.p2>
}}}
This needs an {{{hg ci}}}.
The changes to the spkg look fine. I'm guess I'm OK with the comment
"(not using the usual patches/* procedure, as this is an upstream
patch.)", though I would personally never do things that way -- to me src/
should be pristine.
I give this a positive review, subject to the other doctests in the core
Sage library being fixed to reflect the new package update, e.g., things
like
{{{
wst...@iras:~/screen/iras/sage-4.3.1> ./sage -t
devel/sage/sage/interfaces/gap.py
sage -t "devel/sage/sage/interfaces/gap.py"
**********************************************************************
File
"/home/wstein/screen/iras/sage-4.3.1/devel/sage/sage/interfaces/gap.py",
line 821:
sage: gap.version()
Expected:
'4.4.10'
Got:
'4.4.12'
}}}
-- William
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8076#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
