#8070: New pycrypto-2.0.1.p5.spkg builds 64-bit with Open Solaris x64.
----------------------------+-----------------------------------------------
Reporter: jsp | Owner: drkirkby
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.3.2
Component: porting | Keywords:
Author: Jaap Spies | Upstream: N/A
Reviewer: David Kirkby | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Changes (by drkirkby):
* status: needs_review => positive_review
Comment:
That's fine. In future, it would be helpful if you could show evidence
that the package is building ok, as
{{{
Successfully installed pycrypto-2.0.1.p5
}}}
does not prove very much. Plenty of packages claim to 'sucessfully'
install in Open Solaris, yet in practice they do not. In this case, we can
see:
{{{
copying build/lib.solaris-2.11-i86pc-2.6/Crypto/Cipher/AES.so ->
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-
packages/Crypto/Cipher
copying build/lib.solaris-2.11-i86pc-2.6/Crypto/Cipher/DES3.so ->
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-
packages/Crypto/Cipher
copying build/lib.solaris-2.11-i86pc-2.6/Crypto/Cipher/DES.so ->
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-
packages/Crypto/Cipher
}}}
and using 'file' in the directory, I can indeed see the binaries are now
64-bit.
{{{
drkir...@hawk:~/sage-4.3.1$ file
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-
packages/Crypto/Cipher/*
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-
packages/Crypto/Cipher/AES.so: ELF 64-bit LSB dynamic lib AMD64
Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-
packages/Crypto/Cipher/ARC2.so: ELF 64-bit LSB dynamic lib AMD64
Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-
packages/Crypto/Cipher/ARC4.so: ELF 64-bit LSB dynamic lib AMD64
Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-
packages/Crypto/Cipher/Blowfish.so: ELF 64-bit LSB dynamic lib AMD64
Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-
packages/Crypto/Cipher/CAST.so: ELF 64-bit LSB dynamic lib AMD64
Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-
packages/Crypto/Cipher/DES3.so: ELF 64-bit LSB dynamic lib AMD64
Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-
packages/Crypto/Cipher/DES.so: ELF 64-bit LSB dynamic lib AMD64
Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-
packages/Crypto/Cipher/IDEA.so: ELF 64-bit LSB dynamic lib AMD64
Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-
packages/Crypto/Cipher/__init__.py: English text
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-
packages/Crypto/Cipher/__init__.pyc: data
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-
packages/Crypto/Cipher/RC5.so: ELF 64-bit LSB dynamic lib AMD64
Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-
packages/Crypto/Cipher/XOR.so: ELF 64-bit LSB dynamic lib AMD64
Version 1, dynamically linked, not stripped
drkir...@hawk:~/sage-4.3.1$
}}}
So a positive review from me.
Sorry to sometimes ask for extra things, but it is easier for the reviewer
if he can see evidence this fixes the bug. As I've done many of these
Solaris fixes, and see some from you, I can see ways of improving some
things.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8070#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
