#8104: developer's guide for making spkgs should specify that patches need to be
version controlled
-----------------------------+----------------------------------------------
Reporter: ddrake | Owner: mvngu
Type: defect | Status: new
Priority: major | Milestone: sage-4.3.2
Component: documentation | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
When working on a spkg and adding or modifying patches, the developers'
guide (http://www.sagemath.org/doc/developer/producing_spkgs.html) should
remind developers to version-control the patches.
{{{
19:38 < gsmcwhirter> if some or all of the existing patches no
longer apply, should they be left there or deleted? (on networkx,
there was an edit to a file to switch from numerix to numpy, but
the latest upstream source uses numpy by default)
19:39 < ddrake> I'd delete obsolete patches, and mention that you
did so in SPKG.txt.
19:48 < ddrake> also note that the patches/ directory is version
controlled, so make sure you 'hg add' new patches and 'hg rm'
unneeded ones.
19:51 < mvngu> ddrake: That looks like a sensible thing to do. But
it's not documented at http://www.sagemath.org/doc/developer
/producing_spkgs.html.
19:51 < mvngu> ddrake: Could you open a ticket for this and CC me
on it?
19:51 < ddrake> sure.
19:52 < ddrake> the documentation you just linked to does say "Make
sure that the hg repo contains every file outside the src
directory, and that these are all up-to-date and commited into
the repo."
19:52 < ddrake> but perhaps patches bear a special mention, just to
make it clear. I'll open the ticket.
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8104>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
