#8114: doctest failure in `sage/libs/cremona/newforms.pyx` on 32-bit machines
from
#8042
------------------------------------------+---------------------------------
Reporter: craigcitro | Owner: was
Type: defect | Status: positive_review
Priority: blocker | Milestone: sage-4.3.2
Component: interfaces | Keywords:
Author: Craig Citro, William Stein | Upstream: N/A
Reviewer: William Stein, Craig Citro | Merged:
Work_issues: |
------------------------------------------+---------------------------------
Changes (by newvalueoldvalue):
* status: needs_review => positive_review
* reviewer: => William Stein, Craig Citro
* author: Craig Citro => Craig Citro, William Stein
Comment:
Sure, that's fine. I was expecting that anyone who wanted to know what was
going on would look at #8042, where there's an explanation -- but you're
right, it wouldn't hurt to have at least some explanation in the code
itself. (Basically, my rule of thumb is that anything in an `EXAMPLES`
section needs a good explanation, but for things in the `TESTS` section, a
pointer to a trac ticket is sufficient.)
Positive review -- apply both patches. (William, I'm listing us both as
authors and reviewers, since we each reviewed the other person's
contribution.)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8114#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
