#8044: Categories for finite/permutation/symmetric groups
---------------------------------+------------------------------------------
Reporter: nthiery | Owner: nthiery
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.3.2
Component: group_theory | Keywords: Finite groups, permutation
groups, symmetric groups
Author: Nicolas M. Thiéry | Upstream: N/A
Reviewer: wdj, jlopez | Merged:
Work_issues: |
---------------------------------+------------------------------------------
Changes (by jlopez):
* reviewer: wdj => wdj, jlopez
Comment:
The category part looks fine to me. This is an amazing patch, btw!
I am getting some doctests failures:
{{{
----------------------------------------------------------------------
The following tests failed:
sage -t "devel/sage/doc/en/tutorial/tour_advanced.rst"
sage -t "devel/sage/doc/fr/tutorial/tour_advanced.rst"
sage -t "devel/sage/sage/categories/finite_groups.py"
sage -t "devel/sage/sage/categories/finite_permutation_groups.py"
sage -t "devel/sage/sage/groups/pari_group.py"
sage -t "devel/sage/sage/groups/perm_gps/permgroup_named.py"
sage -t "devel/sage/sage/interfaces/r.py"
sage -t "devel/sage/sage/rings/polynomial/groebner_fan.py"
sage -t
"devel/sage/sage/rings/polynomial/multi_polynomial_ideal.py"
}}}
though they don't seem too serious.
There are a couple of "The category of (multiplicative) finite semigroups"
in the docstrings that should be corrected.
For the rest, assuming that the doctest pass (it might be something with
my sage, will try with a clean install at the office in a couple of
hours), positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8044#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
