#8118: split off Galois representations and modular parametrization from
ell_rational_field.py
-------------------------------+--------------------------------------------
   Reporter:  wuthrich         |       Owner:  cremona                          
                             
       Type:  defect           |      Status:  positive_review                  
                             
   Priority:  major            |   Milestone:  sage-4.3.2                       
                             
  Component:  elliptic curves  |    Keywords:  elliptic curve, galois 
representation, modular parametrization
     Author:                   |    Upstream:  N/A                              
                             
   Reviewer:                   |      Merged:                                   
                             
Work_issues:                   |  
-------------------------------+--------------------------------------------
Changes (by cremona):

  * status:  needs_review => positive_review


Comment:

 I applied the patch to 4.3.2.alpha1:  OK with some fuzz on hunk #7.

 Tests in sage/schemes/elliptic_curves:  all tests (includng long) pass.

 sage -docbuild reference html worked fine for me (it warned about
 {{{
 
/home/jec/sage-4.3.2.alpha1/devel/sage/doc/en/reference/sage/geometry/polytope.rst::
 WARNING: document isn't included in any toctree
 /home/jec/sage-4.3.2.alpha1/devel/sage/doc/en/reference/sage/misc/attach.rst::
 WARNING: document isn't included in any toctree
 }}}
 but that's not from this patch!)

 I have not actually looked at the html docs for the new files yet, but
 will do so.  Meanwhile: positive review.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8118#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to