#8150: various fixes in sage/groups/ and sage/interfaces needed for GAP 4.4.12
------------------------------+---------------------------------------------
Reporter: dimpase | Owner: joyner
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.3.2
Component: group_theory | Keywords:
Author: Dima Pasechnik | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Changes (by robertwb):
* status: positive_review => needs_work
Comment:
I think you misunderstood what I was going for. A test like
{{{
sage: G.<a,b,c> = AbelianGroup(3,[2,3,4]); G
Multiplicative Abelian Group isomorphic to C2 x C3 x C4
sage: w = word_problem([a*b,a*c], b*c); w # random solution
[[a*b, 1], [a*c, 1]]
sage: prod([x^i for x,i in w]) == a
sage: True
}}}
is perfectly fine to have in the EXAMPLES section, perfectly illustrating
the math and the implementation. Much preferable to having a separate TEST
section and a bunch of examples with a #random or #not tested marker.
(FYI, what the #random marker means is "run this test, but ignore the
output" so you don't need it for the "setup" steps. Also, in terms of
patch naming, 13804 is only unique to you--it's usually easier for others
if the patches are named with the ticket number in them.
I'm not trying to be overly judgmental, just trying to give advice that
will make things better. I appreciate the work your putting into this!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8150#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
