#8188: additional functions for linear codes
-----------------------------+----------------------------------------------
Reporter: klee | Owner: klee
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-4.3.2
Component: coding theory | Keywords:
Author: Kwankyu Lee | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Changes (by wdj):
* status: needs_review => needs_work
Comment:
This patch fails to apply to 4.3.2.rc0.
{{{
----------------------------------------------------------------------
| Sage Version 4.3.2.rc0, Release Date: 2010-02-03 |
| Type notebook() for the GUI, and license() for information. |
----------------------------------------------------------------------
**********************************************************************
* *
* Warning: this is a prerelease version, and it may be unstable. *
* *
**********************************************************************
Loading Sage library. Current Mercurial branch is: 8188-coding
sage: hg_sage.apply("/Users/wdj/sagefiles/trac_8188.patch")
cd "/Users/wdj/sagefiles/sage-4.3.2.rc0/devel/sage" && hg status
cd "/Users/wdj/sagefiles/sage-4.3.2.rc0/devel/sage" && hg status
cd "/Users/wdj/sagefiles/sage-4.3.2.rc0/devel/sage" && hg import
"/Users/wdj/sagefiles/trac_8188.patch"
applying /Users/wdj/sagefiles/trac_8188.patch
patching file sage/coding/linear_code.py
Hunk #1 FAILED at 1406
Hunk #2 succeeded at 1416 with fuzz 2 (offset -11 lines).
Hunk #3 succeeded at 1468 with fuzz 1 (offset -2 lines).
Hunk #4 succeeded at 1684 with fuzz 1 (offset 4 lines).
1 out of 4 hunks FAILED -- saving rejects to file
sage/coding/linear_code.py.rej
abort: patch failed to apply
}}}
Please make the following changes
(1) fix the patch so that it applies correctly
(2) Add you name to AUTHOR
(3) Add a short definition of systematic and information set to the
docstrings.
If you do all these, and the patch applies and passes sage -testall then
I'll give this a positive review.
Thanks for working on this!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8188#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
