#8208: Click "No" actually publishes a worksheet in SageNB 0.7.4
----------------------------+-----------------------------------------------
Reporter: mpatel | Owner: was
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-4.3.3
Component: notebook | Keywords:
Author: Mitesh Patel | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Changes (by acleone):
* status: needs_work => needs_review
Comment:
I added a selenium test (test_8208). Here's the output without the fix
{{{
test_3960 (tests.test_accounts.TestAccounts) ... ok
test_4050 (tests.test_accounts.TestAccounts) ... ok
test_4088 (tests.test_accounts.TestAccounts) ... ok
test_3711 (tests.test_worksheet.TestWorksheet) ... ok
test_3957 (tests.test_worksheet.TestWorksheet) ... ok
test_7341 (tests.test_worksheet.TestWorksheet) ... ok
test_7433 (tests.test_worksheet.TestWorksheet) ... ok
test_7434 (tests.test_worksheet.TestWorksheet) ... ok
test_8208 (tests.test_worksheet.TestWorksheet) ... FAIL
test_edit (tests.test_worksheet.TestWorksheet) ... ok
test_operations1 (tests.test_worksheet.TestWorksheet) ... ok
test_simple_evaluation (tests.test_worksheet.TestWorksheet) ... ok
test_7428 (tests.test_worksheet_list.TestWorksheetList) ... ok
test_7444 (tests.test_worksheet_list.TestWorksheetList) ... ok
test_creating_worksheet (tests.test_worksheet_list.TestWorksheetList) ...
ok
test_opening_worksheet (tests.test_worksheet_list.TestWorksheetList) ...
ok
test_searching_for_worksheets
(tests.test_worksheet_list.TestWorksheetList) ... ok
======================================================================
FAIL: test_8208 (tests.test_worksheet.TestWorksheet)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/alex/sage-
dev/sagenb-0.7.4/src/sagenb/sagenb/testing/tests/test_worksheet.py", line
231, in test_8208
self.assertFalse(self.is_worksheet_published('not_p_ws'))
AssertionError
----------------------------------------------------------------------
Ran 17 tests in 384.271s
FAILED (failures=1)
}}}
After the fix:
{{{
test_3960 (tests.test_accounts.TestAccounts) ... ok
test_4050 (tests.test_accounts.TestAccounts) ... ok
test_4088 (tests.test_accounts.TestAccounts) ... ok
test_3711 (tests.test_worksheet.TestWorksheet) ... ok
test_3957 (tests.test_worksheet.TestWorksheet) ... ok
test_7341 (tests.test_worksheet.TestWorksheet) ... ok
test_7433 (tests.test_worksheet.TestWorksheet) ... ok
test_7434 (tests.test_worksheet.TestWorksheet) ... ok
test_8208 (tests.test_worksheet.TestWorksheet) ... ok
test_edit (tests.test_worksheet.TestWorksheet) ... ok
test_operations1 (tests.test_worksheet.TestWorksheet) ... ok
test_simple_evaluation (tests.test_worksheet.TestWorksheet) ... ok
test_7428 (tests.test_worksheet_list.TestWorksheetList) ... ok
test_7444 (tests.test_worksheet_list.TestWorksheetList) ... ok
test_creating_worksheet (tests.test_worksheet_list.TestWorksheetList) ...
ok
test_opening_worksheet (tests.test_worksheet_list.TestWorksheetList) ...
ok
test_searching_for_worksheets
(tests.test_worksheet_list.TestWorksheetList) ... ok
----------------------------------------------------------------------
Ran 17 tests in 381.556s
OK
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8208#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
