#7751: Kazhdan-Lusztig polynomials, Bruhat order, and related features [with
patch, needs review]
-----------------------------+----------------------------------------------
Reporter: bump | Owner: bump
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.3.3
Component: combinatorics | Keywords: Kazhdan-Lusztig, Bruhat order
Author: | Upstream: N/A
Reviewer: roed | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Changes (by roed):
* status: needs_review => needs_work
* reviewer: => roed
Comment:
Looks good. Here are a few comments. After these are addressed, I'll be
happy to give this a positive review.
* `sage/combinat/kazhdan_lusztig.py`
* typo in your e-mail address.
* the method of determining KL._base_ring_type seems a little strange.
Why not use is_Polynomial and isinstance(q, LaurentPolynomial)?
* KazhdanLusztigPolynomial should inherit from SageObject. That allows
pickling, etc.
* `sage/combinat/root_system/weyl_group.py`
*In `WeylGroup_gens`, `__classcall_` needs another trailing underscore.
Include a doctest to make sure that this feature works!
* Can you include a doctest in `WeylGroupElement.__repr__`? I know it's
tested elsewhere, but...
In general, do you have a reason to use `__call__` explicitly, rather than
parentheses? Similarly, you don't need to explicitly call __repr__: using
%s in a string will do that for you automatically.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7751#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
