#7841: Use NTL's ZZ_pEX for polynomial arithmetic over extension fields
----------------------------------+-----------------------------------------
Reporter: ylchapuy | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.3.3
Component: algebra | Keywords: NTL polynomials
Author: ylchapuy | Upstream: N/A
Reviewer: John Cremona, roed | Merged:
Work_issues: |
----------------------------------+-----------------------------------------
Changes (by ylchapuy):
* status: needs_work => needs_review
Comment:
Replying to [comment:9 roed]:
> Looks good. Here are some comments. After a few changes, I'll be happy
to give this a positive review.
>
Thanks a lot for looking at this. I've done almost all the requested
changes, except:
> * `Polynomial_template.__init__` calls `Polynomial.__init__`: you
shouldn't duplicate this earlier in your `__init__` function.
It's not duplicated. When I call it, the method returns before calling
`Polynomial_template.__init__`
> * `_cmp_c_impl` (...) It's also probably better to do this by defining
celement_cmp in the linkage file.
I know it's quite ugly, but I need to compare the elements of the finite
field with the Sage implementation. I don't know how to handle this inside
celement_cmp. If you have an idea, please do it and I would be happy to
review your patch.
Yann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7841#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
