#7927: Extend coleman integration to handle Weierstrass points
-----------------------------+----------------------------------------------
Reporter: robertwb | Owner: was
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.3.3
Component: number theory | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Comment(by kedlaya):
The good news is, this looks fine on mathematical grounds. However, there
are a few procedural issues before I can issue a positive review.
I am getting some doctest failures in hyperelliptic_padic_field.py. I
think the problem is the indentation in the doctest for is_same_disc. If I
fix that by hand, the doctests all pass.
In other news, coverage checking points up some missing
documentation/doctests.
For hyperelliptic_padic_field.py:
{{{
Missing documentation:
* invariant_differential(self):
Missing doctests:
* is_in_weierstrass_disc(self,P):
* is_weierstrass(self,P):
* tiny_integrals(self, F, P, Q):
}}}
For hyperelliptic_generic.py:
{{{
Missing documentation:
* __init__(self, PP, f, h=None, names=None, genus=None):
* change_ring(self, R):
* __cmp__(self, other):
* lift_x(self, x, all=False):
* genus(self):
* jacobian(self):
* monsky_washnitzer_gens(self):
Missing doctests:
* local_coord(self, P, prec = 20, name = 't'):
Possibly wrong (function name doesn't occur in doctests):
* _repr_(self):
* _magma_init_(self, magma):
}}}
Of these, the ones that are new (is_in_weierstrass_disc, is_weierstrass,
and maybe some others) absolutely need doctests. Improving the coverage
for older functions would be helpful but is not an obstacle to a positive
review on this ticket (we could create a separate ticket for that).
Another minor note: various release managers have requested that the
commit line for patches start with the number of the relevant ticket,
e.g.,
#7927: Extend coleman integration to handle Weierstrass points
This is helpful in case a rollback is needed after applying a whole bunch
of disparate patches. This comment can be ignored unless you decide to
build a single patch encompassing all of the changes so far.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7927#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
