#8112: flint fails to build in Open Solaris x64 as 64 bit if CFLAGS is not set
----------------------------+-----------------------------------------------
   Reporter:  jsp           |       Owner:  drkirkby  
       Type:  defect        |      Status:  needs_work
   Priority:  major         |   Milestone:  sage-4.3.3
  Component:  porting       |    Keywords:            
     Author:  Jaap Spies    |    Upstream:  N/A       
   Reviewer:  David Kirkby  |      Merged:            
Work_issues:                |  
----------------------------+-----------------------------------------------
Changes (by drkirkby):

  * status:  needs_review => needs_work


Comment:

 This has been a bit messed up by me, as I made some changes which assumed
 we could set CFLAGS globally, but we can't.

 I'd proposed using CFLAG64 to be the C compiler flag(s) needed to build a
 64-bit binary, which are usually -m64, but might not be. That could be set
 globally, but lets assume for now it is not.

 How would something like this seem:

 If [ -z "$CFLAG64" ] ; then
   CFLAG64=-m64
 fi

 (see how I did this in #8191)

 http://trac.sagemath.org/sage_trac/attachment/ticket/8191/R.patch

 Then simply append $CFLAG64 to FLINT_TUNE. But remove the -m64, as we
 don't need both.

 Since CFLAGS and CXXFLAGS are not set in spkg-install, there is no point
 exporting them. Neither is there any point in exporting CFLAG64 or
 CXXFLAG64 as again they are not used by Flint.

 I think '''all''' that needs to be done is to set CFLAG64 to be -m64
 unless it is set to something else, then ensure that for a 64-bit build,
 FLINT_TUNE gets $CFLAG64 included.

 Dave

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8112#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to