#7832: singular-3-1-0-4-20090818.p2 - fix compilation on FreeBSD
----------------------------+-----------------------------------------------
   Reporter:  pjeremy       |       Owner:  pjeremy                             
       
       Type:  defect        |      Status:  needs_work                          
       
   Priority:  major         |   Milestone:  sage-4.3.3                          
       
  Component:  freebsd       |    Keywords:                                      
       
     Author:  Peter Jeremy  |    Upstream:  Not yet reported upstream; Will do 
shortly.
   Reviewer:                |      Merged:                                      
       
Work_issues:                |  
----------------------------+-----------------------------------------------
Changes (by drkirkby):

  * status:  needs_review => needs_work


Comment:

 Unless I am mistaken, you have modified the singular sources directly,
 which is not permitted. Instead, you should create new versions of the
 files, put them in the 'patches' directory, and have something in spkg-
 install like
 {{{
 cp patch/mod_raw.cc src/kernel/mod_raw.cc
 }}}
 Likewise, you should not change the configure script, or configure.ac, but
 instead have
 {{{
 cp patches/configure src/
 }}}
 and created a diff file between the old configure.ac and the new
 configure.ac and put that in the patches directory.

 Once that is done, it would need testing on Solaris, OS X and Linux in
 addition to FreeBSD.

 Dave

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7832#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to