#5396: Wrapping lcalc library
------------------------------------------+---------------------------------
Reporter: rishi | Owner: Rishi
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.3.4
Component: number theory | Keywords: lcalc
Author: rishi, ylchapuy | Upstream: N/A
Reviewer: John Cremona, David Kirkby | Merged:
Work_issues: |
------------------------------------------+---------------------------------
Changes (by drkirkby):
* status: needs_review => needs_work
Comment:
Replying to [comment:64 drkirkby]:
> Replying to [comment:63 mrubinst]:
> > One more thing- I've also cleaned up my makefile a bit, and, in the
source, got rid of depreciated headers and unused variables.
>
> That is really '''excellent''' news. Is there any chance either you or I
could check this with the Sun compiler on Solaris, before you make an
official release? The Sun compilers more fussy than gcc, but would give us
a performance boost on Solaris.
Having looked at this more closely, you have suppressed warnings, after
I'd gone out of the way to enable them.
You have the options -W and -Wno-deprecated, which are documented at
http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#Warning-Options
as
{{{
-w
Inhibit all warning messages.
-Wno-deprecated
Do not warn about usage of deprecated features. See Deprecated
Features.
}}}
If we follow that link about Deprecated Features, it says "Using the old
features might cause a warning in some cases that the feature will be
dropped in the future. In other cases, the feature might be gone already."
So this appears to be storing up trouble for the future to me.
Given I'd noticed some problems before on Solaris, I made an effort to
highlight the warnings. Now they have gone, as you have suppressed them.
As more minor points:
* This package is .p4, but the changes for .p3 are not documented in
SPKG.txt. If .p3 was never merged into Sage (which I believe is probably
the case), then this should be called .p3 and not .p4. You can overwrite
your old .p3 version.
* It would be useful if the ticket number #5396 was put in SPKG.txt too.
Dave
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5396#comment:68>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
