#7854: speed up edge_connectivity in easy cases
----------------------------+-----------------------------------------------
Reporter: ncohen | Owner: rlm
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.3.4
Component: graph theory | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Changes (by ncohen):
* status: needs_work => needs_review
Comment:
Hello !!
It was even worse than this... The patch made Sage check manually if the
graph was 1- or 2-connected, even if the user requested the weights on the
edges to be taken into account, which would clearly have returned wrong
results at some point, as the speedup only considered the graph's
topology. It now checks this option is set to False. I also set it to
False by default, so that the user will be able to enjoy these speed-ups.
Anyway, I think it is best not to use the edges' weights by default. I
very frequently deal with graph having tuples as labels to remember a lot
of informations, and this function wouldn't like it at all :-)
(several minutes later)
Ahem... And I also noticed a bug that had me worried for a while. When
testing docstrings, I found that the PappusGraph was only 1-connected
instead of 3-connected, and the LP seemed to be in fault. In the end, I
just noticed I had called "g" the strongly connected orientation, which
was the main graph's name !!!!!
Better this way... ;-)
Thank you for your help !
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7854#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
