#8418: Reduced Rauzy graph
-----------------------------+----------------------------------------------
Reporter: jleroy | Owner: jleroy
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-4.3.4
Component: combinatorics | Keywords:
Author: jleroy | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Changes (by abmasse):
* status: needs_review => needs_work
Comment:
Hello Julien ! Thanks for this new function that will be really helpful !
I have some minor comments, though.
1. When using the notation `u[i,j]` with Latex formatting, it is better
not to put `[i,j]` in index position.
2. There is a typo in IMPUT.
3. Since the output is a directed graph, I would put "digraph" instead of
"a graph". The "a" is not necessary and "digraph" is more precise.
4. You should put some text between your example blocks, to explain what
you're doing and what you want to show. For instance, between blocks 1 and
2, you could write "For the Fibonacci word..." and between blocks 2 and 3,
something like "It works also for periodic words.". Note that this is
optional, it just helps the user to understand how you would use the
function.
Short of that, your code looks good. Next time will probably be a positive
review !
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8418#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
