#8112: flint fails to build in Open Solaris x64 as 64 bit since FLINT_TUNE is 
not
set
----------------------------+-----------------------------------------------
   Reporter:  jsp           |       Owner:  drkirkby       
       Type:  defect        |      Status:  positive_review
   Priority:  major         |   Milestone:  sage-4.3.4     
  Component:  porting       |    Keywords:                 
     Author:  Jaap Spies    |    Upstream:  N/A            
   Reviewer:  David Kirkby  |      Merged:                 
Work_issues:                |  
----------------------------+-----------------------------------------------
Changes (by drkirkby):

  * status:  needs_review => positive_review


Comment:

 Your fix resolves the issues we have, and is unlikely to break anything
 (see below for a possible exception). I do have a few comments that are
 worth documenting.

  * I was a bit concerned that -funroll-loops will be enabled when SAGE64
 is set to yes, despite the fact that it supposed to crash on an UltraSPARC
 III+ processor. (Previously -funroll-loops was disabled on Solaris SPARC).
 However, testing showed this will '''not''' build on Solaris 10 in 64-bit
 mode on SPARC, irrespective of whether -funroll-loops is set or not.
 Therefore the inclusion of -funroll-loops is not causing any extra
 problems on SPARC, and might actually improve performance when the issues
 are resolved on 64-bit SPARC.

  * There was no need to export CXXFLAG64, as Flint will not use it, but it
 can do no harm whatsoever.

  * I'm changing the title slightly, from CFLAGS to FLINT_TUNE, as CFLAGS
 is not used directly in the spkg-install. It is FLINT_TUNE that gets set

 {{{
 drkir...@redstart:~/fresh/sage-4.3.3/spkg/standard/flint-1.5.0.p4$ grep
 CFLAGS spkg-install
 drkir...@redstart:~/fresh/sage-4.3.3/spkg/standard/flint-1.5.0.p4$
 }}}

 Positive review.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8112#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to