#8452: Code check: Pickling of nested classes
----------------------------+-----------------------------------------------
Reporter: mpatel | Owner: tbd
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-4.3.4
Component: misc | Keywords:
Author: Mitesh Patel | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Comment(by hivert):
Replying to [comment:1 mpatel]:
> I've adapted `sage.misc.nested_class.modify_for_nested_pickle`, so that
we can put the check in `conf.py` instead of `sage_autodoc.py`. We may
not need to patch Sphinx. Please test and let me know if this works.
>
> Note: The patch depends on #7448.
Hi Mitesh,
As far as I understand, the goal of this ticket is twofold:
- make the check optional;
- put it in a sage plugin of sphinx to avoig patching Sphinx for that.
So you still relies on sphinx to do this check. As I previously said, a
priori, checking for nested class has nothing to do with Sphinx.
Though I definitely don't know where to do it, if possible, it would even
be better to do it in sage eg. during the import of the class... Any idea
on this way ? Maybe it's not possible without patching {{{type}}} which is
exactly what {{{NestedClassMetaclass}}} does, at least conceptually.
By the way, am I allowed to review this patch (there is some code from me
in it) ?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8452#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
