#8477: Force GNU make to build PALP serially
----------------------------+-----------------------------------------------
Reporter: mpatel | Owner: tbd
Type: defect | Status: needs_work
Priority: minor | Milestone: sage-4.3.4
Component: packages | Keywords:
Author: Mitesh Patel | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Changes (by drkirkby):
* status: needs_review => needs_work
Comment:
Your changes to SPKG.txt are good, but the mention of only "GPL" did cause
me to check the license.
A look at the file src/COPYING shows only a link to the GPL, which is of
course now version 3. The file does not contain the usual contents of the
file COPYING.
Looking at the history of PALP
http://hep.itp.tuwien.ac.at/~kreuzer/CY/CYpalp.html#History
I can see that version 1.1 (the latest, and the release in Sage) is dated
November 2, 2006, which was before the GPL 3 existed.
I believe SPKG.txt's license information should indicate the license is
GPL2+, rather than GPL, but the reason for this needs to be given.
Something along the lines of
* When released, GPL 2 was in force.
* There is a link to a web page, which now points to GPL 3, but would
have pointed to GPL 2 at the time of the package was released.
* Therefore one can deduce the authors were happy for this to be released
under GPL 2 or a later version.
One other minor point, it would be good to remove the line:
CC=gcc
from Makefile, as that would then allow one to at least attempt to build
this with any compiler. The Makefile refers to $(CC) everywhere, so since
CC is set by the Sage environment, this line could be usefully removed,
but I realise this is unrelated to the main part of the change, so don't
bother unless you feel inclined to.
I will need to check the changes don't break the build (I can't believe
they can do any harm whatsoever, but I can't actually check them just
now). But once the SPKG.txt is revised, I'll give this a positive review,
subject to me checking it does not break a serial build, which will take
me a minute or two. (I'll check the parallel build issues as part of the
#7071).
Perhaps you could also attach a Mercurical patch file, which makes
reviewing a little easier.
Once those changes are made, I'll check that the package builds serially.
Then I'll revisit #7071, as that relies on this anyway. Hopefully this
will allow #7071 to be resolved soon, as I believe that is a great
enhancement, but we need to be sure it can't break anything.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8477#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
