#8505: random points on elliptic curve misses half the group
-------------------------------+--------------------------------------------
Reporter: robertwb | Owner: cremona
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.3.4
Component: elliptic curves | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-------------------------------+--------------------------------------------
Comment(by cremona):
My patch (after reviewing and testing the whole sage library) has to be
applied *instead* of Robert's, though it still has his tag on it (sorry).
It does two things relative to his:
1. I changed a few doctest outputs for the random point tests. I am
worried though, since these changes were not only replacing a point by its
negative! Why?
2. testing with -long revealed a bug in sqrt() for integer-mods: when
0 then the return was 0 and not [0] which broke the new code since it uses
the all=true option. This was *only* revealed in the -long test! Take
note!!
I left this as "needs review" since it needs someone else (e.g. robertwb)
to check my change, especially the one at 2. above, and also I would like
to hear views on my other remark under 1.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8505#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
