#8484: incremental improvements to prove_BSD
-------------------------------+--------------------------------------------
Reporter: rlm | Owner: AlexGhitza
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.3.4
Component: elliptic curves | Keywords:
Author: Robert Miller | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-------------------------------+--------------------------------------------
Comment(by cremona):
It would have been nice to have had some description of what the patch
contains!
I am happy with the main part: applies fine to 4.3.4.alpha1, and all tests
in sage/schemes/elliptic_curves pass.
But I am puzzled about the need for your small_rank_curves function: we
already have cremona_curves() and cremona_optimal_curves(), as defined in
ell_rational_field but using an iterator defined in
sage/databases/cremona. Would it not be more sensible to add an option to
that (specifically, to iter_optimal(), list_optimal()) which gives
optional filtering data such as a list of ranks? (Other posibilities, in
addition: list of possible torsion, etc).
If you can justify this function's existence, then it should go in another
place, probably in ell_rational_field just after cremona_optimal_curves.
But for that I would give this a positive review!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8484#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
