#8370: Add tour_functions to the French tutorial (cf. #5463)
-------------------------------+--------------------------------------------
Reporter: mmezzarobba | Owner: mmezzarobba
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-4.4
Component: documentation | Keywords:
Author: Marc Mezzarobba | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-------------------------------+--------------------------------------------
Comment(by mmezzarobba):
Sorry for the delay.
Replying to [comment:2 abmasse]:
> This is a good idea. If I'm alright, this patch is adding a missing
section to the French tutorial that is mainly a translation of the same
section (already present) in English ?
Indeed.
Replying to [comment:5 abmasse]:
> I reviewed your patch. Everything is ok, I made a few changes which are
not errors, but mainly suggestions, so if you don't agree with any of it,
feel very free to remove them or tell me to remove them. To summarize, I
did the following modifications.
>
> 1. Since the tabbing is four spaces for Python code in general (not
mandatory, but encouraged), I reformatted your examples so that they all
start at distance four from the beginning of the lines.
Here I just stuck to the style of the English version. But you are right
that (most?) other sections of the original tutorial use four spaces.
> 2. For the sage blocks illustrating your examples, you always put `::`
alone on a line, while you could put it at the end of the preceding text
explaining the example. The effect is that the sentence ends with `:` and
the block example follows. This is not a mistake, but this is what I've
seen in other patches.
Same here, except that the format with `::` on its own line seems to be
used consistently in the tutorial (in both languages). I don't think it's
a big deal anyway.
However, in some cases, you put a space between the `::` and the preceding
word, so that there is no colon (and no period either) in the output. Was
that deliberate?
> 3. I did some rephrasing. These are only suggestions, if you don't agree
with all or some of it, let me know.
>
> 4. You forgot to put the word "plot" between backticks in one place. I
corrected that.
Seems fine to me. Btw, I also checked that the our patches apply correctly
on top of 4.3.4 + patches from #8242.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8370#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
