#8609: Switch AmbientSpace and Scheme to Parent
----------------------------------+-----------------------------------------
Reporter: novoselt | Owner: AlexGhitza
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.4
Component: algebraic geometry | Keywords:
Author: Andrey Novoseltsev | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------------+-----------------------------------------
Changes (by novoselt):
* status: needs_info => needs_review
Comment:
Replying to [comment:2 cremona]:
> Patch applies fine to 4.3.5. Testing all and will report back....
>
> Andrey, what exactly is the motivation for this? I see no harm in it,
but you must have had a reason for making the change!
Yeah, I should have probably explained it better. I am working on support
for (Fano) toric varieties and Calabi-Yau hypersurfaces/complete
intersections inside (with a hope to finish by this summer). So when I was
going over schemes/general to figure out what is already there and what do
I need to do to fit nicely into existing framework, I got this question:
http://groups.google.com/group/sage-
devel/browse_thread/thread/ddb9f2c592082c02/4120466d01cacae0#4120466d01cacae0
and wrote the patch. It took me a while to post it due to those Segfaults
that ALWAYS were appearing with the patch during non-parallel testing,
although in different/unrelated places. Now I did manage to get at least
one clean run and think that it should go in. After all, as I understand
it, if this patch causes problems, it is because it exposes some deeper
bugs in Sage and it actually can be nice if they become more visible...
I also wanted to make the following change (I don't have a ready-to-review
patch for this one, but can make one quickly), but nobody got interested
in discussing it and I don't think such changes should happen silently:
http://groups.google.com/group/sage-
devel/browse_thread/thread/1279e373341da951/e0efa737426d5b19#e0efa737426d5b19
Thank you!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8609#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.