#5969: implement computation of rational cuspidal subgroups of modular abelian
varieties
-----------------------------+----------------------------------------------
Reporter: was | Owner: was
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.4
Component: number theory | Keywords:
Author: William Stein | Upstream: N/A
Reviewer: Alex Ghitza | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Changes (by newvalueoldvalue):
* status: needs_review => needs_work
* reviewer: => Alex Ghitza
* author: => William Stein
Comment:
The "part2" patch changes some things in
{{{matrix/matrix_integer_dense.pyx}}}, and that causes two doctest
failures:
{{{
sage -t -long "devel/sage/sage/modules/fg_pid/fgp_module.py"
**********************************************************************
File
"/mnt/usb1/scratch/ghitza/sage-4.3.5-sage.math.washington.edu-x86_64-Linux/devel/sage/sage/modules/fg_pid/fgp_module.py",
line 1131:
sage: phi = Q.hom([0,V.0,V.1]); phi
Expected:
Morphism from module over Integer Ring with invariants (2, 0, 0) to
module with invariants (0, 0, 0) that sends the generators to [(0, 0, 0),
(0, 0, 1), (0, 1, 0)]
Got:
Morphism from module over Integer Ring with invariants (2, 0, 0) to
module with invariants (0, 0, 0) that sends the generators to [(0, 0, 0),
(1, 0, 0), (0, 1, 0)]
**********************************************************************
File
"/mnt/usb1/scratch/ghitza/sage-4.3.5-sage.math.washington.edu-x86_64-Linux/devel/sage/sage/modules/fg_pid/fgp_module.py",
line 1139:
sage: phi(Q.1)
Expected:
(0, 0, 1)
Got:
(1, 0, 0)
**********************************************************************
}}}
It was not obvious to me whether this was harmless or an actual problem.
The rest looks good, there are a couple of docstring fixes but I have a
reviewer patch that can take care of them.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5969#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
