#7914: Implementation of triangular morphisms for modules with basis
---------------------------------+------------------------------------------
Reporter: jbandlow | Owner: jbandlow
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.4
Component: categories | Keywords:
Author: Jason Bandlow | Upstream: N/A
Reviewer: Nicolas M. Thiéry | Merged:
Work_issues: |
---------------------------------+------------------------------------------
Changes (by newvalueoldvalue):
* cc: adrien.boussica...@… (added)
* reviewer: nthiery => Nicolas M. Thiéry
* status: needs_review => positive_review
* author: jbandlow => Jason Bandlow
Comment:
Replying to [comment:8 jbandlow]:
> Fixed. The only change between the new patch and the previous one is
line 1076 of modules_with_basis.py, in the `invert` method:
>
> {{{
> - domain = self.domain(), codomain =
self.codomain(),
> + domain = self.codomain(), codomain =
self.domain(),
> }}}
Yes, Adrien had noticed this, and was about to fix it in the Sage-Combinat
queue. Since this patch is not yet in Sage, I agree that it's best to
include the fix right away in it. Positive review!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7914#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
