#8071: Trivial kernel of a matrix over non-fields are broken
-------------------------------+--------------------------------------------
   Reporter:  rbeezer          |       Owner:  was         
       Type:  defect           |      Status:  needs_review
   Priority:  minor            |   Milestone:  sage-4.4    
  Component:  linear algebra   |    Keywords:              
     Author:  Rob Beezer       |    Upstream:  N/A         
   Reviewer:  Martin Albrecht  |      Merged:              
Work_issues:                   |  
-------------------------------+--------------------------------------------
Changes (by rbeezer):

  * reviewer:  => Martin Albrecht


Comment:

 Replying to [comment:3 malb]:
 > Patch applies cleanly, looks good, doctests pass. The only nitpick I
 have is: shouldn't {{{:meth:`sage.modules.free_module.VectorSpace`}}} be
 {{{class:...}}}?
 >
 > If that's fixed then this patch gets a positive review.

 Hi Martin,

 Thanks for the review on this one.  New patch contains everything, plus
 two changes in the docstring for {{{_right_kernel_trivial()}}} in
 {{{sage/matrix/matrix2.py}}} - both substitute "class" for "meth".  I am
 forever making that mistake - thanks for catching these.

 Release manager - apply only the "dash-2" patch.

 Rob

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8071#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to