#8641: "sage -t" should exit with nonzero exit code if doctests fail
---------------------------+------------------------------------------------
   Reporter:  ddrake       |       Owner:  tbd
       Type:  enhancement  |      Status:  new
   Priority:  minor        |   Milestone:     
  Component:  doctest      |    Keywords:     
     Author:               |    Upstream:  N/A
   Reviewer:               |      Merged:     
Work_issues:               |  
---------------------------+------------------------------------------------

Comment(by jhpalmieri):

 I'm following up on the discussion at the end of #7995.

 First, the code {{{err = err // 256}}} seems okay: putting a print
 statement at the end of that python function shows that {{{err}}} seems to
 have an appropriate value.

 Other parts of the python code in sage-test confuse me, though. It seems
 to me that the function {{{test_file}}} always returns 0 (if the file
 exists), regardless of the success or failure of the test.  The function
 {{{test}}} has a return value which depends on whether tests passed, but
 {{{test_file}}} never uses the return value from {{{test}}}, does it?

 In practice, if I run {{{sage -sh}}} and then do {{{sage-doctest}}} on a
 file with errors, I get a nonzero return value, but if I run {{{sage-
 test}}} on the same file, I get a return value of 0.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8641#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to